Cross-Realm Krb5 Patch

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Cross-Realm Krb5 Patch

Zachary Kotlarek
I've updated my krb5 cross-realm auth patch for dovecot 1.1-rc4; there  
are not any (intentional) changes in functionality from the last  
patch, the diff just didn't apply cleanly anymore. As before the most  
recent version of the patch is available at:
        http://zinux.cynicbytrade.com/svn/servers/dovecot/cross-realm.diff.bz2

I see the cross-realm patch for Solaris made it into the mainline.  
What if anything can I do to encourage the mainline adoption of my non-
Solaris patch?

        Zach

smime.p7s (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Cross-Realm Krb5 Patch

Timo Sirainen
On Fri, 2008-05-02 at 17:49 -0500, Zachary Kotlarek wrote:
> I've updated my krb5 cross-realm auth patch for dovecot 1.1-rc4; there  
> are not any (intentional) changes in functionality from the last  
> patch, the diff just didn't apply cleanly anymore. As before the most  
> recent version of the patch is available at:
> http://zinux.cynicbytrade.com/svn/servers/dovecot/cross-realm.diff.bz2

I changed the code to be a bit more Dovecot-like, wrapped it in #ifdef
HAVE_GSSAPI_KRB5 to make it easier to disable if it fails somewhere,
added some more error handling and added krb5_free_context() which I
guess is needed to avoid leaking memory?

Can you test if it still works after my changes?
http://hg.dovecot.org/dovecot-1.1/rev/841209428d2d


signature.asc (196 bytes) Download Attachment