Dovecot 2.3.9 fails on FreeBSD

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Dovecot 2.3.9 fails on FreeBSD

Dovecot mailing list
Hi

I've just tried to build the latest Dovecot 2.3.9 on FreeBSD 11.3.
Without success...It fails on the following commit which was introduced
in 2.3.9:
https://github.com/dovecot/core/commit/c85f1bc3ce612c736c9d2c468cc08306db1b5851

Following output is the build log: https://pastebin.com/3nvSeDn8

So I guess it has to do with some changes FreeBSD made:
https://reviews.freebsd.org/D18630


What do you guys think?


Greetings Pascal

Reply | Threaded
Open this post in threaded view
|

Re: Dovecot 2.3.9 fails on FreeBSD

Dovecot mailing list
On Wed, Dec 04, 2019 at 18:06:58 +0100, Pascal Christen via dovecot wrote:

> Hi
>
> I've just tried to build the latest Dovecot 2.3.9 on FreeBSD 11.3.
> Without success...It fails on the following commit which was introduced
> in 2.3.9:
> https://github.com/dovecot/core/commit/c85f1bc3ce612c736c9d2c468cc08306db1b5851
>
> Following output is the build log: https://pastebin.com/3nvSeDn8
>
> So I guess it has to do with some changes FreeBSD made:
> https://reviews.freebsd.org/D18630

As far as I can tell, dovecot should be checking for the existence of
EAI_ADDRFAMILY and EAI_NODATA.

The good news is, a quick workaround is to remove the two lines that use
these two constants.  (A correct patch would do the proper checks.)

Jeff.

--
Bad pun of the week: The formula 1 control computer suffered from a race
condition
Reply | Threaded
Open this post in threaded view
|

Re: Dovecot 2.3.9 fails on FreeBSD

Dovecot mailing list
On Wed, Dec 04, 2019 at 12:19:35 -0500, Josef 'Jeff' Sipek via dovecot wrote:

> On Wed, Dec 04, 2019 at 18:06:58 +0100, Pascal Christen via dovecot wrote:
> > Hi
> >
> > I've just tried to build the latest Dovecot 2.3.9 on FreeBSD 11.3.
> > Without success...It fails on the following commit which was introduced
> > in 2.3.9:
> > https://github.com/dovecot/core/commit/c85f1bc3ce612c736c9d2c468cc08306db1b5851
> >
> > Following output is the build log: https://pastebin.com/3nvSeDn8
> >
> > So I guess it has to do with some changes FreeBSD made:
> > https://reviews.freebsd.org/D18630
>
> As far as I can tell, dovecot should be checking for the existence of
> EAI_ADDRFAMILY and EAI_NODATA.
>
> The good news is, a quick workaround is to remove the two lines that use
> these two constants.  (A correct patch would do the proper checks.)

Ok.  That was easy.  I'm going to get the following patch reviewed and
committed.

Jeff.

diff --git a/src/lib/net.c b/src/lib/net.c
--- a/src/lib/net.c
+++ b/src/lib/net.c
@@ -1068,13 +1068,17 @@ enum net_hosterror_type net_get_hosterro
  int error;
  enum net_hosterror_type type;
  } error_map[] = {
+#ifdef EAI_ADDRFAIMILY /* Obsoleted by RFC 2553bis-02 */
  { EAI_ADDRFAMILY, NET_HOSTERROR_TYPE_NOT_FOUND },
+#endif
  { EAI_AGAIN, NET_HOSTERROR_TYPE_NAMESERVER },
  { EAI_BADFLAGS, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
  { EAI_FAIL, NET_HOSTERROR_TYPE_NAMESERVER },
  { EAI_FAMILY, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
  { EAI_MEMORY, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
+#ifdef EAI_NODATA /* Obsoleted by RFC 2553bis-02 */
  { EAI_NODATA, NET_HOSTERROR_TYPE_NOT_FOUND },
+#endif
  { EAI_NONAME, NET_HOSTERROR_TYPE_NOT_FOUND },
  { EAI_SERVICE, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
  { EAI_SOCKTYPE, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
Reply | Threaded
Open this post in threaded view
|

Re: Dovecot 2.3.9 fails on FreeBSD

Dovecot mailing list
I'm working on the port as we type.  I've already done this patch (will add the comments). 



On Wed, Dec 4, 2019 at 11:29 AM Josef 'Jeff' Sipek via dovecot <[hidden email]> wrote:
On Wed, Dec 04, 2019 at 12:19:35 -0500, Josef 'Jeff' Sipek via dovecot wrote:
> On Wed, Dec 04, 2019 at 18:06:58 +0100, Pascal Christen via dovecot wrote:
> > Hi
> >
> > I've just tried to build the latest Dovecot 2.3.9 on FreeBSD 11.3.
> > Without success...It fails on the following commit which was introduced
> > in 2.3.9:
> > https://github.com/dovecot/core/commit/c85f1bc3ce612c736c9d2c468cc08306db1b5851
> >
> > Following output is the build log: https://pastebin.com/3nvSeDn8
> >
> > So I guess it has to do with some changes FreeBSD made:
> > https://reviews.freebsd.org/D18630
>
> As far as I can tell, dovecot should be checking for the existence of
> EAI_ADDRFAMILY and EAI_NODATA.
>
> The good news is, a quick workaround is to remove the two lines that use
> these two constants.  (A correct patch would do the proper checks.)

Ok.  That was easy.  I'm going to get the following patch reviewed and
committed.

Jeff.

diff --git a/src/lib/net.c b/src/lib/net.c
--- a/src/lib/net.c
+++ b/src/lib/net.c
@@ -1068,13 +1068,17 @@ enum net_hosterror_type net_get_hosterro
                int error;
                enum net_hosterror_type type;
        } error_map[] = {
+#ifdef EAI_ADDRFAIMILY /* Obsoleted by RFC 2553bis-02 */
                { EAI_ADDRFAMILY, NET_HOSTERROR_TYPE_NOT_FOUND },
+#endif
                { EAI_AGAIN, NET_HOSTERROR_TYPE_NAMESERVER },
                { EAI_BADFLAGS, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
                { EAI_FAIL, NET_HOSTERROR_TYPE_NAMESERVER },
                { EAI_FAMILY, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
                { EAI_MEMORY, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
+#ifdef EAI_NODATA /* Obsoleted by RFC 2553bis-02 */
                { EAI_NODATA, NET_HOSTERROR_TYPE_NOT_FOUND },
+#endif
                { EAI_NONAME, NET_HOSTERROR_TYPE_NOT_FOUND },
                { EAI_SERVICE, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
                { EAI_SOCKTYPE, NET_HOSTERROR_TYPE_INTERNAL_ERROR },


--
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 214-642-9640 (c)     E-Mail: [hidden email]
US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106
Reply | Threaded
Open this post in threaded view
|

Re: Dovecot 2.3.9 fails on FreeBSD

Dovecot mailing list
In reply to this post by Dovecot mailing list
Thanks, build passed on FreeBSD 11.3

Greetings Pascal
Reply | Threaded
Open this post in threaded view
|

Re: Dovecot 2.3.9 fails on FreeBSD

Dovecot mailing list
On Wed, Dec 04, 2019 at 18:41:45 +0100, Pascal Christen wrote:
> Thanks, build passed on FreeBSD 11.3

It turns out I had a typo in the patch I posted on the mailing list.  I
corrected the typo and it builds fine on 12.1.

Jeff.

       -#ifdef EAI_ADDRFAIMILY /* Obsoleted by RFC 2553bis-02 */
       +#ifdef EAI_ADDRFAMILY /* Obsoleted by RFC 2553bis-02 */
Reply | Threaded
Open this post in threaded view
|

Re: Dovecot 2.3.9 fails on FreeBSD

Dovecot mailing list
In reply to this post by Dovecot mailing list
Ignore me, I'm talking about the FreeBSD port, not the actual upstream sources.

Sorry for the noise.


On Wed, Dec 4, 2019 at 11:40 AM Larry Rosenman <[hidden email]> wrote:
I'm working on the port as we type.  I've already done this patch (will add the comments). 



On Wed, Dec 4, 2019 at 11:29 AM Josef 'Jeff' Sipek via dovecot <[hidden email]> wrote:
On Wed, Dec 04, 2019 at 12:19:35 -0500, Josef 'Jeff' Sipek via dovecot wrote:
> On Wed, Dec 04, 2019 at 18:06:58 +0100, Pascal Christen via dovecot wrote:
> > Hi
> >
> > I've just tried to build the latest Dovecot 2.3.9 on FreeBSD 11.3.
> > Without success...It fails on the following commit which was introduced
> > in 2.3.9:
> > https://github.com/dovecot/core/commit/c85f1bc3ce612c736c9d2c468cc08306db1b5851
> >
> > Following output is the build log: https://pastebin.com/3nvSeDn8
> >
> > So I guess it has to do with some changes FreeBSD made:
> > https://reviews.freebsd.org/D18630
>
> As far as I can tell, dovecot should be checking for the existence of
> EAI_ADDRFAMILY and EAI_NODATA.
>
> The good news is, a quick workaround is to remove the two lines that use
> these two constants.  (A correct patch would do the proper checks.)

Ok.  That was easy.  I'm going to get the following patch reviewed and
committed.

Jeff.

diff --git a/src/lib/net.c b/src/lib/net.c
--- a/src/lib/net.c
+++ b/src/lib/net.c
@@ -1068,13 +1068,17 @@ enum net_hosterror_type net_get_hosterro
                int error;
                enum net_hosterror_type type;
        } error_map[] = {
+#ifdef EAI_ADDRFAIMILY /* Obsoleted by RFC 2553bis-02 */
                { EAI_ADDRFAMILY, NET_HOSTERROR_TYPE_NOT_FOUND },
+#endif
                { EAI_AGAIN, NET_HOSTERROR_TYPE_NAMESERVER },
                { EAI_BADFLAGS, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
                { EAI_FAIL, NET_HOSTERROR_TYPE_NAMESERVER },
                { EAI_FAMILY, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
                { EAI_MEMORY, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
+#ifdef EAI_NODATA /* Obsoleted by RFC 2553bis-02 */
                { EAI_NODATA, NET_HOSTERROR_TYPE_NOT_FOUND },
+#endif
                { EAI_NONAME, NET_HOSTERROR_TYPE_NOT_FOUND },
                { EAI_SERVICE, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
                { EAI_SOCKTYPE, NET_HOSTERROR_TYPE_INTERNAL_ERROR },


--
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 214-642-9640 (c)     E-Mail: [hidden email]
US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106


--
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 214-642-9640 (c)     E-Mail: [hidden email]
US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106
Reply | Threaded
Open this post in threaded view
|

Re: Dovecot 2.3.9 fails on FreeBSD

Dovecot mailing list
In reply to this post by Dovecot mailing list
On Wed, 4 Dec 2019 18:06:58 +0100, Pascal Christen via dovecot stated:

>Hi
>
>I've just tried to build the latest Dovecot 2.3.9 on FreeBSD 11.3.
>Without success...It fails on the following commit which was introduced
>in 2.3.9:
>https://github.com/dovecot/core/commit/c85f1bc3ce612c736c9d2c468cc08306db1b5851
>
>Following output is the build log: https://pastebin.com/3nvSeDn8
>
>So I guess it has to do with some changes FreeBSD made:
>https://reviews.freebsd.org/D18630
>
>
>What do you guys think?
>
>
>Greetings Pascal

The official FreeBSD ports system does not even have the Dovecot 2.3.9
port available yet. I think it is a little premature to start making
changes or modifications until the port maintainer has had a chance to
avail himself of the problem, if one exists.

--
Jerry
Reply | Threaded
Open this post in threaded view
|

Re: Dovecot 2.3.9 fails on FreeBSD

Dovecot mailing list
He's the maintainer ;)

> The official FreeBSD ports system does not even have the Dovecot 2.3.9
> port available yet. I think it is a little premature to start making
> changes or modifications until the port maintainer has had a chance to
> avail himself of the problem, if one exists.
>
Reply | Threaded
Open this post in threaded view
|

Re: Dovecot 2.3.9 fails on FreeBSD

Dovecot mailing list

On Wed, Dec 4, 2019 at 11:55 AM Pascal Christen via dovecot <[hidden email]> wrote:
He's the maintainer ;)

> The official FreeBSD ports system does not even have the Dovecot 2.3.9
> port available yet. I think it is a little premature to start making
> changes or modifications until the port maintainer has had a chance to
> avail himself of the problem, if one exists.
>


--
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 214-642-9640 (c)     E-Mail: [hidden email]
US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106
Reply | Threaded
Open this post in threaded view
|

Re: Dovecot 2.3.9 fails on FreeBSD

Dovecot mailing list
In reply to this post by Dovecot mailing list
On Wed, 4 Dec 2019 18:54:52 +0100, Pascal Christen via dovecot stated:
>He's the maintainer ;)
>
>> The official FreeBSD ports system does not even have the Dovecot
>> 2.3.9 port available yet. I think it is a little premature to start
>> making changes or modifications until the port maintainer has had a
>> chance to avail himself of the problem, if one exists.

My original reply was supposed to be direct at
"<[hidden email]>". I think that somehow that got lost in
the transmission. I had not even seen Larry's response at that time.

In any case, I did not mean any disrespect to anyone.

--
Jerry